Skip to content

improve: event filtering algorithm for multiple parallel updates #3155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
csviri merged 6 commits into from
Feb 6, 2026
Merged

improve: event filtering algorithm for multiple parallel updates #3155

csviri merged 6 commits into from
Feb 6, 2026

Conversation

@csviri
Copy link
Collaborator

@csviri csviri commented Feb 4, 2026

Signed-off-by: Attila Mészáros a_meszaros@apple.com

@openshift-ci openshift-ci bot requested review from metacosm and xstefank February 4, 2026 20:18
@csviri csviri changed the title improve: adding test for repeated caching and filtering update improve: event filtering algorithm for multiple parallel updates Feb 4, 2026
@csviri csviri requested a review from shawkins February 4, 2026 21:02
@csviri csviri linked an issue Feb 4, 2026 that may be closed by this pull request
Comparable Resource Versions in Kubernetes #2944
Open
5 tasks
shawkins
shawkins reviewed Feb 4, 2026
View reviewed changes
Copy link
Collaborator

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. To drive home the usage pattern you could consider collapsing decreaseActiveUpdates, handleLastOwnUpdatedResourceVersion, and getActiveUpdates to a single call -

int decreaseActiveUpdates(String resourceVersion)

@csviri csviri requested a review from shawkins February 5, 2026 08:20
@csviri
Copy link
Collaborator Author

csviri commented Feb 5, 2026

This makes sense. To drive home the usage pattern you could consider collapsing decreaseActiveUpdates, handleLastOwnUpdatedResourceVersion, and getActiveUpdates to a single call -

int decreaseActiveUpdates(String resourceVersion)

did some simplification; feel free to do additional (in this or separate pr),

and mainly thank you for feedback!

metacosm
metacosm reviewed Feb 5, 2026
View reviewed changes
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't follow the latest changes in this area so I'm not qualified to assert the validity of this PR.

csviri added 6 commits February 5, 2026 17:56
@csviri
improve: adding test for repeated caching and filtering update
a0892a4 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
wip
80bdb4a 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
wip
bded229 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
wip
935a8b6 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
wip
f21faad 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
wip
818bc0d 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri csviri force-pushed the test-double-update branch from f7e28b8 to 818bc0d Compare February 5, 2026 16:56
@csviri csviri merged commit a182791 into operator-framework:next Feb 6, 2026
71 of 94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@metacosm metacosm metacosm left review comments

@xstefank xstefank xstefank approved these changes

@shawkins shawkins Awaiting requested review from shawkins

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Comparable Resource Versions in Kubernetes

4 participants

@csviri @metacosm @shawkins @xstefank